Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): change ubuntu 20.10 to use lib32gcc-s1 #3094

Merged
merged 1 commit into from
Nov 14, 2020
Merged

fix(deps): change ubuntu 20.10 to use lib32gcc-s1 #3094

merged 1 commit into from
Nov 14, 2020

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Nov 11, 2020

Description

changes the dependency for ubuntu 20.10 to lib32gcc-s1

Fixes #3093

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 linked an issue Nov 11, 2020 that may be closed by this pull request
Ubuntu has renamed lib32gcc1 to lib32gcc-s1, so dependency check for lib32gcc1 using dpkg-query fails on testing Ubuntu 20.10 and unstable. #3093
Closed
@dgibbs64 dgibbs64 added this to the v20.6.0 milestone Nov 14, 2020
@dgibbs64 dgibbs64 merged commit 5add746 into GameServerManagers:develop Nov 14, 2020
@h3o66 h3o66 deleted the fix/ubuntu-2010 branch November 22, 2020 14:42
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgibbs64 dgibbs64 dgibbs64 approved these changes

Assignees
No one assigned
Labels
distro: Ubuntu info: dependency type: bug Something isn't working
Projects
None yet
Milestone
v20.6.0
2 participants
@h3o66 @dgibbs64